Conversation
Owner
|
The pull request isn't clean (wrong dates and contains my own commits). I'm working on a Contributor License Agreement for the next major version of libmodbus 3.3/3.4 (not for v3.2) before spending time on this feature I want to sure you're willing to accept it. |
Contributor
Author
|
Ok, I have re-based my branch onto the current master. Yes, there are some common function in the RTU and ASCII part and as well in the TCP part. What will be the exceptions I have to except in you Contributor License Agreement? |
Owner
|
A better implementation has been provided in #275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch adds modbus Ascii Support. It implements a new modbus_new_ascii() function for to open an Ascii Port.